Hey Equestriaghoul,
I have not had surgery yet, but I am confident that I will get at least a somewhat decent result. I am going to Dr Kim in Korea.
As with any surgery, a lot depends on the technique and the skill of the surgeon.
With some of them such as Dr Kim, there is a solid track record, and even some that have said they were dissatisfied actually sound pretty good. Also, the procedure is endoscopic which means they don't make an incision, so it is pretty safe.
With some of the other, older procedures, they are pretty invasive and less than effective. I believe this is why people have said that voice surgery is ineffective and risky. But we have come a long way since then, even though many surgeons are still doing the older procedures.
I would urge you to look through at least the Yeson and Dr Haben threads, as these are among the more popular options.
Also, if you say you are going on blockers, it seems as though you're a teenager? You may not need the surgery at all, but that is up to you.