If I had to think about the reduced risk of prostate and testicular cancer and how afraid I am of that disease, that's a benefit for me.
Also saying goodbye to accidental erections. There's nothing worse on the gym's showers. "Go down, you bastard. Now it's not the time for that!"
But thinking about being on meds for life, possible social problems or harassing, unsupporting family, etc... Not so sure. there may be a few physical benefits for daily annoyances, but a lot of extra crap to deal with.
being trans is not bad, but the "normal" people are awful.