PERSONALLY I don't think speedos look good on any guy. For swim team, I don't mind them much, but I prefer those tight mid-thigh ones. But this is just my opinion, I know plenty of other guys disagree.
But, it's up to you. If you think that's what you want, then go for it. Looking at the description of the pocket on that one, I think it depends on whether you'd be comfortable packing in that or not. I'd be too worried about losing my dick, but I'm also pretty paranoid about that even when there's no way it will fall out.